Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_designs): Dual DC example #2326

Merged
merged 28 commits into from
Feb 9, 2023

Conversation

xaviramon
Copy link
Contributor

Change Summary

Documentation to build a twin DC using DC GW as interconnection.

Example is being built using the single DC as starting point. Comprehension of first example is required to understand this example.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Add new example documentation.

How to test

Follow the example.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@xaviramon xaviramon requested a review from a team as a code owner December 12, 2022 15:20
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Dec 12, 2022
@JulioPDX
Copy link
Contributor

Hi @xaviramon, I left some suggestions. Please let me know if you have any questions. Great PR and thank you for the contribution. Could you please add an addition to the mkdocs.yml file to have this example added?

Example:

nav:
  - Home: README.md
  - Getting Started:
      - Introduction to Ansible and AVD: docs/getting-started/intro-to-ansible-and-avd.md
      - Example for Single DC L3LS: examples/single-dc-l3ls/README.md
      - Example for Dual DC L3LS: examples/dual-dc-l3ls/README.md

Thank you!

@xaviramon
Copy link
Contributor Author

Thanks for the comments @JulioPDX . Added them in the document.
I am unsure about the modification of contributing.md file. Is this expected from some change in the lint files?

@JulioPDX
Copy link
Contributor

Thanks for the comments @JulioPDX . Added them in the document. I am unsure about the modification of contributing.md file. Is this expected from some change in the lint files?

Oddly enough, this file is not displayed in our doc site. Are these changes by pre-commit?

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 3, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev3 milestone Feb 4, 2023
@ClausHolbechArista
Copy link
Contributor

@xaviramon please review the last commit fa1feca

@xaviramon
Copy link
Contributor Author

LGTM all changes + include in molecule!

@ClausHolbechArista ClausHolbechArista merged commit 11de290 into aristanetworks:devel Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Doc(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants