Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add Ipv6 management variables #2335

Merged
merged 15 commits into from
Mar 13, 2023

Conversation

emilarista
Copy link
Contributor

Change Summary

Adds ipv6 mgmt variables to turn on v6 addressing/static routes in the mgmt vrf.

Related Issue(s)

Fixes #2309

Component(s) name

arista.avd.eos_designs

Proposed changes

# Fabric variables
ipv6_mgmt_gateway: < v6 address >
ipv6_mgmt_destination_networks:
  - < IPv6_network/Mask >
  - < IPv6_network/Mask >

# Node variables
< node type key>:
  nodes:
    < node >:
      ipv6_mgmt_ip: < v6 address/mask >

How to test

Tested with molecule

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 14, 2022
@emilarista emilarista changed the title Ipv6 mgmt vars Feat(eos_designs): Add Ipv6 management variables Dec 14, 2022
Copy link
Contributor

@onurgashi onurgashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks very much @emilarista

@ClausHolbechArista
Copy link
Contributor

Is this one ready or still WIP?

@emilarista emilarista marked this pull request as ready for review January 20, 2023 13:17
@emilarista emilarista requested a review from a team as a code owner January 20, 2023 13:17
@emilarista
Copy link
Contributor Author

Is this one ready or still WIP?

My bad, forgot. Marked ready now.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@emilarista emilarista force-pushed the ipv6_mgmt_vars branch 2 times, most recently from d26ea42 to 9181a22 Compare March 1, 2023 09:19
@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit 11fe0b9 into aristanetworks:devel Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
CH-PROJECT-01
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Management with IPv6 only
4 participants