Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add schema validation to eos_designs action plugins #2350

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Feat(eos_designs): Add schema validation to eos_designs action plugins #2350

merged 6 commits into from
Feb 3, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Dec 22, 2022 •
edited
Loading

Change Summary

Add schema validation to eos_designs action plugins

Component(s) name

arista.avd.eos_designs_facts
arista.avd.yaml_templates_to_facts

Proposed changes

  • Add input variable conversion and validation using common libs to EOS Designs action plugins.
  • Update documentation

How to test

Since we don't have any schemas yet, I tested locally with some draft schemas.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation role: eos_designs issue related to eos_designs role labels Dec 22, 2022
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jan 6, 2023
Merged
4 tasks
@carlbuchmann carlbuchmann self-requested a review January 17, 2023 16:00
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 17, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed state: conflict PR with conflict type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR labels Jan 18, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review January 18, 2023 08:04
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner January 18, 2023 08:04
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs): Add schema validation to eos_designs action plugins Feat(eos_designs): Add schema validation to eos_designs action plugins Jan 18, 2023
gmuloc
gmuloc reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method run in yaml_template_to_facts is very big maybe some bits of logic could be moved to some separate functions (e.g. all the self.dest handling)

ansible_collections/arista/avd/plugins/modules/yaml_templates_to_facts.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/yaml_templates_to_facts.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/yaml_templates_to_facts.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/eos_designs_facts.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/eos_designs_facts.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/tasks/main.yml Show resolved Hide resolved
ansible_collections/arista/avd/plugins/modules/eos_designs_facts.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/eos_designs_facts.py Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/eos_designs_facts.py Show resolved Hide resolved
ansible_collections/arista/avd/plugins/action/eos_designs_facts.py Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev2 milestone Jan 27, 2023
gmuloc
gmuloc approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit cc67f6b into aristanetworks:devel Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role
Projects
None yet
Milestone
v4.0.0-dev2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @gmuloc