Fix(eos_designs): Handle overlapping VLAN names for l2vlans and vlan-aware-bundles

[ClausHolbechArista]

Change Summary

Handle overlapping VLAN names for l2vlans and vlan-aware-bundles

Related Issue(s)

Fixes #2387

Component(s) name

arista.avd.eos_designs

Proposed changes

• Add molecule test with overlapping vlan names
• Fix logic to add all vlans with the same name to the same bundle
• Fix typo in multicast molecule (duplicate vlan name), since it got triggered by this fix.

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[adietrich-ussignal]

I ran this with VLANs 2200-2202 having the same name. Looks like the config generated as expected:

   vlan-aware-bundle name_2200
      rd 10.255.12.7:15200
      route-target both 15200:15200
      redistribute learned
      vlan 2200-2202

[gmuloc]

LGTM - quite a lot of changes in molecule explainable with

1. Wrong VLAN name for the EVPN_MULTICAST_TESTS
2. change from int to str for the vlans because now using list_compress to cater for ranges.

[ClausHolbechArista]

I ran this with VLANs 2200-2202 having the same name. Looks like the config generated as expected:

   vlan-aware-bundle name_2200
      rd 10.255.12.7:15200
      route-target both 15200:15200
      redistribute learned
      vlan 2200-2202

Thank you for testing this out in your environment. We will get this fix in asap.

[adietrich-ussignal]

Given this impacts the name of all existing vlan-aware-bundles (in my environment), would there be a negative effect when these get renamed within the configuration?

[carlbuchmann]

LGTM

[carlbuchmann]

Given this impacts the name of all existing vlan-aware-bundles (in my environment), would there be a negative effect when these get renamed within the configuration?

@adietrich-ussignal - I'll reach out to you with @mthiel117 to review.