Feat(eos_config_deploy_cvp)!: Support for dynamic inventories

[ClausHolbechArista]

Change Summary

Add capability to read inventory from memory instead of yaml file

Related Issue(s)

Fixes #2063

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

• Make inventory argument optional and default to reading from memory
• Implement action plugin to read from memory using Ansible's InventoryManager object
• Remove default inventory file value
• Add optional "avd_inventory_to_container_file" variable to force reading from file.

How to test

• Updated molecule scenario
• Updated integration tests

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[JulioPDX]

Testing with ATD (left everything default), I get the following error

TASK [arista.avd.eos_config_deploy_cvp : Generate intended variables] *******************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: NoneType: None
fatal: [cv_atd1]: FAILED! => {"changed": false, "msg": "arista.avd.inventory_to_container: Group 'ATD_LEAFS' has more than one parent group ({ATD_TENANTS_NETWORKS, ATD_FABRIC, ATD_SERVERS}) below the 'container_root'. Unable to build CloudVision container hierarchy."}

[ClausHolbechArista]

Testing with ATD (left everything default), I get the following error

TASK [arista.avd.eos_config_deploy_cvp : Generate intended variables] *******************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: NoneType: None
fatal: [cv_atd1]: FAILED! => {"changed": false, "msg": "arista.avd.inventory_to_container: Group 'ATD_LEAFS' has more than one parent group ({ATD_TENANTS_NETWORKS, ATD_FABRIC, ATD_SERVERS}) below the 'container_root'. Unable to build CloudVision container hierarchy."}

Thank you for testing. Apparently there is a mistake in that inventory, where the ATD_TEANATS_NETWORKS and ATD_SERVERS are configured inside ATD_FABRIC instead of at the same level. This makes the ATD_LEAFS have three "parents", so not a clean tree structure.

I reproduced this with an integration test, and the current yml parsing simply creates these groups with no devices in them.
How do we want to proceed? @carlbuchmann

1. Try to keep the current behavior, so simply take the first parent group and ignore the rest? The risk here is that we pick the wrong one, like in your output above, the first one is ATD_TENANTS_NETWORKS. Maybe I can improve the code to get a predictable ordering.

2. Make this a breaking change highlighting the new stricter behavior in RN and docs

Remember that if someone insists on the current behavior, they can just configure the avd_inventory_to_container_file: "{{ inventory_file }}"

[carlbuchmann]

1. Try to keep the current behavior, so simply take the first parent group and ignore the rest? The risk here is that we pick the wrong one, like in your output above, the first one is ATD_TENANTS_NETWORKS. Maybe I can improve the code to get a predictable ordering.
2. Make this a breaking change highlighting the new stricter behavior in RN and docs

Remember that if someone insists on the current behavior, they can just configure the avd_inventory_to_container_file: "{{ inventory_file }}"

+1 on option # 2 to make this a breaking change. Let's start the porting guide to describe the behavior change and how we can retain existing behavior.