Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Support for custom masks in l3_edge ip pools #2466

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Feat(eos_designs): Support for custom masks in l3_edge ip pools #2466

merged 9 commits into from
Feb 3, 2023

Conversation

philippebureau
Copy link
Contributor

@philippebureau philippebureau commented Jan 25, 2023 •
edited

Change Summary

Add support for custom subnet masks in eos_desings l3_edge ip pools

Component(s) name

arista.avd.eos_desings

Proposed changes

l3_edge:
  p2p_links_ip_pools:
    - name: < p2p_pool_name_1 >
      ipv4_pool_mask: < subnet mask size | default -> 31 >

How to test

See molecule scenario CORE_UNIT_TESTS.yml

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 25, 2023
@philippebureau philippebureau changed the title L3 edge pool mask Feature(eos_designs): Support for custom masks in l3_edge ip pools Jan 25, 2023
@philippebureau philippebureau changed the title Feature(eos_designs): Support for custom masks in l3_edge ip pools Feat(eos_designs): Support for custom masks in l3_edge ip pools Jan 25, 2023
@philippebureau philippebureau marked this pull request as ready for review January 25, 2023 15:42
@philippebureau philippebureau requested a review from a team as a code owner January 25, 2023 15:42
ClausHolbechArista
ClausHolbechArista approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation. Thank you for this addition.

@ClausHolbechArista
Copy link
Contributor

@philippebureau if you have time, it would be useful to implement the same in core_interfaces. It has 95% identical data model and code.

@philippebureau
Copy link
Contributor Author

@philippebureau if you have time, it would be useful to implement the same in core_interfaces. It has 95% identical data model and code.

I'll take a look at core_interfaces

@philippebureau
Copy link
Contributor Author

@philippebureau if you have time, it would be useful to implement the same in core_interfaces. It has 95% identical data model and code.

I'll take a look at core_interfaces

PR 2469 submitted for the core_interfaces implementation of the prefix_size
(#2469)

tgodaA
tgodaA approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 0be37b4 into aristanetworks:devel Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA tgodaA approved these changes

Assignees

@philippebureau philippebureau

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philippebureau @ClausHolbechArista @gmuloc @tgodaA