Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Support for custom masks in core_interfaces ip pools #2469

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Feat(eos_designs): Support for custom masks in core_interfaces ip pools #2469

merged 2 commits into from
Mar 14, 2023

Conversation

philippebureau
Copy link
Contributor

@philippebureau philippebureau commented Jan 26, 2023 •
edited

Change Summary

Add support for custom subnet masks in eos_desings core_interfaces ip pools

Related Issue(s)

none

Component(s) name

arista.avd.eos_designs

Proposed changes

core_interfaces:
  p2p_links_ip_pools:
    - name: < p2p_pool_name_1 >
      prefix_size: < subnet mask size | default -> 31 >

How to test

See molecule test MPLS-CORE.yml

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 26, 2023
@philippebureau philippebureau changed the title initial commit Feat(eos_desings): Support for custom masks in core_interfaces ip pools Jan 26, 2023
@philippebureau philippebureau changed the title Feat(eos_desings): Support for custom masks in core_interfaces ip pools Feat(eos_designs): Support for custom masks in core_interfaces ip pools Jan 26, 2023
@philippebureau philippebureau marked this pull request as ready for review January 26, 2023 17:53
@philippebureau philippebureau requested a review from a team as a code owner January 26, 2023 17:53
@philippebureau philippebureau mentioned this pull request Jan 26, 2023
Merged
4 tasks
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 13, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc merged commit 2e90644 into aristanetworks:devel Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA left review comments

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@philippebureau philippebureau

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philippebureau @gmuloc @ClausHolbechArista @tgodaA