Fix(eos_designs): Fix error with dotted hostname, l2leaf and mlag #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausHolbechArista
added
cherry-pick-for-3.8.x
gmuloc
reviewed
Feb 9, 2023
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_facts.py
Show resolved
Hide resolved
github-actions
bot
added
the
state: CI Updated
carlbuchmann
pushed a commit
to carlbuchmann/avd
that referenced
this pull request
Feb 13, 2023
carlbuchmann
removed
the
cherry-pick-for-3.8.x
ClausHolbechArista
added a commit
that referenced
this pull request
Feb 14, 2023
) (#2534) Co-authored-by: Claus Holbech <holbech@arista.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix error with dotted hostname, l2leaf and mlag
Related Issue(s)
When having dots in the hostname for l2leafs with mlag, we see errors during eos_designs_facts phase:
Component(s) name
arista.avd.eos_designsProposed changes
Fix fetching of mlag peer facts for l2leafs to handle dots in hostnames. Similar to how we do it elsewhere.
How to test
Tested with customer repo.
Checklist
User Checklist
Repository Checklist