Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for passive BGP neighbor #2568

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Feat(eos_cli_config_gen): Add support for passive BGP neighbor #2568

merged 6 commits into from
Mar 9, 2023

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Feb 23, 2023

Change Summary

Add support for the following CLI at peer group level and neighbor level (both global neighbor and inside VRF):

router bgp 1234
  neighbor PEER-GROUP1 passive
  neighbor x.x.x.x passive
  vrf VRF1
    neighbor y.y.y.y passive

Related Issue(s)

Fixes #2566

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added "passive" key at peer-group level, global neighbor and VRF neighbor

How to test

See molecule tests

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested a review from a team as a code owner February 23, 2023 12:22
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 23, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 25, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista requested a review from a team March 9, 2023 06:22
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev7 milestone Mar 9, 2023
gmuloc
gmuloc approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 6afcfe2 into aristanetworks:devel Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gusmb gusmb

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev7
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add support for passive BGP neighbor
3 participants
@gusmb @gmuloc @ClausHolbechArista