Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for shell for local users #2581

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 27, 2023

Change Summary

Add support for shell for local users

Related Issue(s)

Fixes #2354

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding the shell option in the schema with valid_values as per EOS CLI

Leaf1(config)#username blah shell ?
  /bin/bash      Specify /bin/bash as shell
  /bin/sh        Specify /bin/sh as shell
  /sbin/nologin  Specify /sbin/nologin as shell
local_users:
    documentation_options:
      filename: data_model/Authentication
    type: list
    primary_key: name
    convert_types:
    - dict
    items:
        [...]
        shell:
          type: str
          description: 'Specify shell for the user

            '
          valid_values:
          - /bin/bash
          - /bin/sh
          - /sbin/nologin

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner February 27, 2023 16:11
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 27, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit 2ab3d1b into aristanetworks:devel Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support shell option for local-users
3 participants