-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add ipv6 dhcp relay to vlan/ethernet-interfaces #2585
Feat(eos_cli_config_gen): Add ipv6 dhcp relay to vlan/ethernet-interfaces #2585
Conversation
5642b64
to
3498983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- is it on purpose to not have this figuring in the documentation (I guess that is fine as we would still have the interface config in the documentation)
- seems like this is also supported under ethernet interfaces but not yet in AVD - is there a plan to add it there afterwards?
...ions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/vlan_interfaces.schema.yml
Show resolved
Hide resolved
...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/vlan-interfaces.yml
Outdated
Show resolved
Hide resolved
I did not add a table for this as we currently don't have it for ipv4 helpers, we rely on interface config documentation for that. I can go ahead and add it for ipv6 dhcp if desired and open a new PR to add it for ipv4 helpers as well.
Good point, i will add it to ethernet interfaces as well. |
No need for 1 I would say :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided CI finishes, LGTM
Change Summary
Adds ipv6_dhcp_relay_destinations data model to vlan interfaces.
Related Issue(s)
Fixes #2310
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Tested with molecule and on physical device.
Repository Checklist