Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add ipv6 dhcp relay to vlan/ethernet-interfaces #2585

Merged
merged 8 commits into from
Mar 10, 2023

Conversation

emilarista
Copy link
Contributor

Change Summary

Adds ipv6_dhcp_relay_destinations data model to vlan interfaces.

Related Issue(s)

Fixes #2310

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

vlan_interfaces:
  Vlan123:
    ipv6_dhcp_relay_destinations:
      - address: < ipv6 address >
        vrf: < vrf >
        local_interface: < interface >
        source_address: < ipv6 address >
        link_address: < ipv6 address >

How to test

Tested with molecule and on physical device.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 28, 2023
@emilarista emilarista marked this pull request as ready for review March 1, 2023 14:09
@emilarista emilarista requested a review from a team as a code owner March 1, 2023 14:09
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. is it on purpose to not have this figuring in the documentation (I guess that is fine as we would still have the interface config in the documentation)
  2. seems like this is also supported under ethernet interfaces but not yet in AVD - is there a plan to add it there afterwards?

@emilarista
Copy link
Contributor Author

Two questions:

  1. is it on purpose to not have this figuring in the documentation (I guess that is fine as we would still have the interface config in the documentation)

I did not add a table for this as we currently don't have it for ipv4 helpers, we rely on interface config documentation for that. I can go ahead and add it for ipv6 dhcp if desired and open a new PR to add it for ipv4 helpers as well.

  1. seems like this is also supported under ethernet interfaces but not yet in AVD - is there a plan to add it there afterwards?

Good point, i will add it to ethernet interfaces as well.

@gmuloc
Copy link
Contributor

gmuloc commented Mar 7, 2023

Two questions:

  1. is it on purpose to not have this figuring in the documentation (I guess that is fine as we would still have the interface config in the documentation)

I did not add a table for this as we currently don't have it for ipv4 helpers, we rely on interface config documentation for that. I can go ahead and add it for ipv6 dhcp if desired and open a new PR to add it for ipv4 helpers as well.

  1. seems like this is also supported under ethernet interfaces but not yet in AVD - is there a plan to add it there afterwards?

Good point, i will add it to ethernet interfaces as well.

No need for 1 I would say :) Thanks!

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided CI finishes, LGTM

@emilarista emilarista changed the title Feat(eos_cli_config_gen): Add ipv6 dhcp relay to vlan-interfaces Feat(eos_cli_config_gen): Add ipv6 dhcp relay to vlan/ethernet-interfaces Mar 7, 2023
@gmuloc gmuloc requested a review from a team March 9, 2023 10:22
@ClausHolbechArista ClausHolbechArista merged commit 29c6cf5 into aristanetworks:devel Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 DHCP Relay in eos_cli_config_gen
3 participants