-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(plugins): Add arista.avd.batch_template action plugin #2593
Feat(plugins): Add arista.avd.batch_template action plugin #2593
Conversation
0b9da99
to
d3f450a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some section in the README.md for now as well (and yes we shall endeavour to automate this ;) )
ansible_collections/arista/avd/plugins/action/batch_template.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/action/batch_template.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
no tests added since this will be part of schema documentation pre-commit, once we merge this feature.
Change Summary
Add arista.avd.batch_template action plugin
Component(s) name
arista.avd.batch_template
Proposed changes
Creating batch_template plugin which can template multiple files without use of Ansible loops. The major downside of Ansible loops is that they are single-process, so all templating happens in serial. In
batch_template
we perform the templating in forks (respectingansible_forks
value).How to test
Tested offline using schema documentation generation.
Checklist
User Checklist
Repository Checklist