Feat(eos_cli_config_gen): add cvsourceintf flag to TerminAttr

[noredistribution]

Change Summary

Add support for cvsourceintf (available since TerminAttr 1.23.0+) to replace cvsourceip (which is unique per device)

Related Issue(s)

Fixes #2619

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added cvsourceintf to TerminAttr flags

How to test

daemon_terminattr:
   cvaddrs: # For single cluster
       - 192.0.2.100:9910
  cvauth:
     method: "token"
     key: "arista"
     token_file: "/tmp/token"
  cvvrf: MGMT
  ingestexclude: "/Sysdb/cell/1/agent,/Sysdb/cell/2/agent"
  smashexcludes: "ale,flexCounter,hardware,kni,pulse,strata"
  cvsourceintf: Loopback10

would result in

daemon TerminAttr
   exec /usr/bin/TerminAttr -cvaddr=192.0.2.100:9910 -cvauth=token,/tmp/token -cvvrf=MGMT -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs -cvsourceintf=Loopback10
   no shutdown

or multi-cluster streaming config:

daemon_terminattr:
  clusters: # For multiple cluster support
    dublin:
        cvaddrs:
        - 192.0.2.100:9910
        - 192.0.2.101:9910
        - 192.0.2.102:9910
        cvauth:
          method: "token"
          token_file: "/tmp/token"
        cvvrf: MGMT
        cvsourceintf: Loopback10
    cvaas:
        cvaddrs:
          - www.arista.io:443
        cvauth:
          method: "token-secure"
          token_file: "/tmp/prod"
        cvvrf: MGMT
        cvsourceintf: Vlan560
  ingestexclude: "/Sysdb/cell/1/agent,/Sysdb/cell/2/agent"
  smashexcludes: "ale,flexCounter,hardware,kni,pulse,strata"

would result in:

daemon TerminAttr
   exec /usr/bin/TerminAttr -cvopt cvaas.addr=www.arista.io:443 -cvopt cvaas.auth=token-secure,/tmp/prod -cvopt cvaas.vrf=MGMT -cvopt cvaas.sourceintf=Vlan560 -cvopt dublin.addr=192.0.2.100:9910,192.0.2.101:9910,192.0.2.102:9910 -cvopt dublin.auth=token,/tmp/token -cvopt dublin.vrf=MGMT -cvopt dublin.sourceintf=Loopback10 -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs
   no shutdown

Checklist

User Checklist

• N/A

Repository Checklist

• [ x] My code has been rebased from devel before I start
• [ x] I have read the CONTRIBUTING document.
• [ x] My change requires a change to the documentation and documentation have been updated accordingly.
• [ x] I have updated molecule CI testing accordingly. (check the box if not applicable)

[ClausHolbechArista]

I see a lot of unrelated changes on this PR - most likely caused by missing libyaml support. Try ansible --verison and check for libyaml = True.

[gmuloc]

Only comment would be to test also in the cluster mode if possible to make sure what is rendered there is correct as well.

[noredistribution]

Only comment would be to test also in the cluster mode if possible to make sure what is rendered there is correct as well.

sorry yea, wanted to push it last night but my AIO container was failing, just managed to do it now