Fix(eos_designs): Handle overlapping vlan numbers with filter.only_in_use and trunkgroups

[ClausHolbechArista]

Change Summary

Handle overlapping vlan numbers with filter.only_vlans_in_use and trunkgroups

Related Issue(s)

Issue seen in deployment, where duplicate vlans were erroneously configured because the matching on trunk groups was done too lazy (converting to vlan numbers and thereby loosing information about trunk group)

Component(s) name

arista.avd.eos_designs

Proposed changes

Refactor vlan filtering to address corner cases

• Set list of trunk groups as fact so filtering can be done on trunk groups in network_services code
• Split endpoint_vlans and endpoint_trunk_groups into separate properties for local, mlag and downstream switches.
• Use sets instead of converting back and forth in internal functions.
• Various optimizations.

How to test

First commit in this PR adds a molecule example of the issue. This is a snip from the output with only that commit:

TASK [arista.avd.eos_designs : Generate device configuration in structured format] ***
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.arista.avd.plugins.plugin_utils.errors.errors.AristaAvdError: Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'.
fatal: [trunk-group-tests-l2leaf4 -> localhost]: FAILED! => {"changed": false, "msg": "Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'."}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.arista.avd.plugins.plugin_utils.errors.errors.AristaAvdError: Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'.
fatal: [trunk-group-tests-l3leaf2a -> localhost]: FAILED! => {"changed": false, "msg": "Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'."}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.arista.avd.plugins.plugin_utils.errors.errors.AristaAvdError: Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'.
fatal: [trunk-group-tests-l3leaf2b -> localhost]: FAILED! => {"changed": false, "msg": "Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'."}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.arista.avd.plugins.plugin_utils.errors.errors.AristaAvdError: Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'.
fatal: [trunk-group-tests-l2leaf3 -> localhost]: FAILED! => {"changed": false, "msg": "Duplicate VLAN ID '200' found in Tenant 'TRUNK_GROUP_TESTS' during configuration of SVI in VRF 'TG_200'. Other VLAN is in Tenant 'TENANT_WITH_DUPLICATE_VLANS'."}

The second commit contains the fix.

No configurations are changed as part of this fix/refactor.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[gmuloc]

LGTM - I still would recommend documenting "somewhere centralized" (maybe artificially a section in the currently very big file) how the full logic is working for the block of endpoints/trunk groups.

[carlbuchmann]

LGTM - replicated the issue locally and tested PR.