Refactor(eos_cli_config_gen,eos_designs): Deprecate isis_af_defaults and address_family knobs #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gmuloc
changed the title
emilarista
force-pushed
the
isis_af_refactor
branch
from
649d3a2
to
741fdb0
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
reviewed
Mar 29, 2023
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/router_isis.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/router_isis.py
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
rebasing
rebasing rebasing
rebasing rebasing
rebasing
…s/underlay/router_isis.py Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
rebasing
emilarista
force-pushed
the
isis_af_refactor
branch
from
3b8386d
to
0ba4472
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…s/schema_fragments/router_isis.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
carlbuchmann
requested changes
Apr 27, 2023
gmuloc
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds deprecation warnings for outdated isis_af_defaults and address_family knobs, moves old knobs to deprecation molecule scenario for eos_cli_config_gen and makes eos_designs output updated variables.
Requires #2616
Related Issue(s)
Fixes #1299
Component(s) name
arista.avd.eos_cli_config_genarista.avd.eos_designsProposed changes
Updated schemas with deprecation warnings, altered eos_designs python modules.
How to test
Ran molecule, made sure no or only intended changes in intended config occur.
Repository Checklist