Fix(eos_cli_config_gen): Fix documentation template for flow tracking #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where generation of flow tracking documentation for devics without port-channels was raising errors.
github-actions
bot
added
the
role: eos_cli_config_gen
|
This issue also affects v3.8.x as far as I can see, so in my opinion it would be good to cherry-pick this to a maintenance release as well. |
carlbuchmann
added
the
cherry-pick-for-3.8.x
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/flow-trackings.j2
Show resolved
Hide resolved
Handle the scenario where flow tracking is defined on a device with no `ethernet_interfaces` defined by defaulting to and empty list.
ClausHolbechArista
changed the title
ClausHolbechArista
approved these changes
Mar 17, 2023
carlbuchmann
pushed a commit
to carlbuchmann/avd
that referenced
this pull request
Mar 20, 2023
carlbuchmann
removed
the
cherry-pick-for-3.8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where generation of flow tracking documentation for devics without port-channels was raising errors.
Change Summary
Add
arsita.avd.default([])to the loop to default to an empty list ifport_channel_interfacesis not defined.Related Issue(s)
Fixes #2635
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Add
arsita.avd.default([])to the loop to default to an empty list ifport_channel_interfacesis not defined.How to test
To test, run eos_cli_config_gen on a structured config that has flow_trackings defined, but without having any port_channels.
Checklist
User Checklist
Repository Checklist