Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for BGP session tracking #2659

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 24, 2023

Change Summary

Implement BGP session tracker

Related Issue(s)

Fixes #2653

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added the following schema to router-bgp

bgp:
  neighbors:
    type: list
    primary_key: ip_address
    item:
      type: dict
      keys:
+       session_tracker:
+       type: str
  peer_groups:
    type: list
    primary_key: name
    item:
      type: dict
      keys:
+       session_tracker:
+       type: str
[...]
+      session_trackers:
+        type: list
+        primary_key: name
+        items:
+          type: dict
+          keys:
+            name:
+              type: str
+              description: Name of session tracker
+            recovery_delay:
+              type: int
+              description: Recovery delay in seconds
+              convert_types:
+                - str
+              min: 1
+              max: 3600

Added the following schema to ethernet interfaces and port-channel interfaces

        bgp:
          type: dict
          keys:
            session_tracker:
              type: str
              description: Name of session tracker

How to test

Added tests to molecule eos_cli_config_gen scenario

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner March 24, 2023 16:05
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Mar 24, 2023
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 24, 2023
@gmuloc
Copy link
Contributor Author

gmuloc commented Mar 24, 2023

@dgonzalez85 - please have a look and in particular documentation may not be complete. Let us know what makes sense!

@@ -193,4 +209,8 @@ router bgp 65101
network 2001:db8:100::/40
network 2001:db8:200::/40 route-map RM-BAR-MATCH
redistribute static route-map RM-IPV6-STATIC-TO-BGP
session tracker ST1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands look incorrectly indented to me, only 2 instead of 3 spaces. Both for the session tracker command and the recovery delay under it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - addressed in 76c6075

@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev9 milestone Mar 31, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 9c1fc2a into aristanetworks:devel Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BGP session tracker support
4 participants