Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Configure "ip routing ipv6 interface vrf X" for RFC5549 #2660

Merged
merged 11 commits into from
Mar 31, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 27, 2023

Change Summary

Renders correctly the ip routing ipv6 interfaces vrf X config for RFC5549 VRFs as reported in the linked issue.
Add support for it in eos_cli_config_gen and fix documentation and a couple of issues.

Related Issue(s)

Fixes #2646

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

  • Add configuration of ip routing ipv6 interfaces vrf X knob to eos_cli_config_gen
  • Adjust eos_cli_config_gen documentation templates to show the information for ip routing ipv6 interfaces
  • Fix a bug where AVD renders ipv6 unicast-routing vrf default which is converted to ipv6 unicast-routing
  • Stop rendering ip routing when ip routing ipv6 interfaces is configured in eos_designs
  • Render ip routing ipv6 interfaces vrf X in VRF where it is required based on the underlay/overlat RFC5549 variables from eos_designs

How to test

molecule scenario and particularly the evpn_underlay_rfc5549_overlay_ebgp one

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

…in VRF

* Change documentation templates to render ip routing ipv6 interfaces in
  ip routing section
…s for rfc 5549

* Remove generating `ip routing` when `ip routing ipv6 interfaces` is
  True
@gmuloc
Copy link
Contributor Author

gmuloc commented Mar 27, 2023

@onurgashi please take a look at this as a starting point

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 27, 2023
@gmuloc gmuloc marked this pull request as ready for review March 27, 2023 12:36
@gmuloc gmuloc requested a review from a team as a code owner March 27, 2023 12:36
* Fix check in `eos_designs` to ALSO check for overlay_rfc5549
* Change documentation template
@gmuloc gmuloc requested review from ClausHolbechArista and a team March 31, 2023 12:28
@gmuloc gmuloc added this to the v4.0.0-dev9 milestone Mar 31, 2023
@carlbuchmann carlbuchmann added cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later type: bug Something isn't working labels Mar 31, 2023
@carlbuchmann carlbuchmann self-requested a review March 31, 2023 13:52
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549 Fix(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549 Mar 31, 2023
@gmuloc gmuloc merged commit 797e704 into aristanetworks:devel Mar 31, 2023
38 checks passed
@gmuloc gmuloc changed the title Fix(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549 Fix(eos_designs): Configure "ip routing ipv6 interface vrf X" for RFC5549 Mar 31, 2023
carlbuchmann added a commit to carlbuchmann/avd that referenced this pull request Apr 14, 2023
…face vrf X" for RFC5549 (aristanetworks#2660)

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Apr 14, 2023
carlbuchmann added a commit that referenced this pull request Apr 14, 2023
…face vrf X" for RFC5549 (#2660) (#2733)

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC5549 IPv4 routing in overlay broken due to missing config
3 participants