-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Configure "ip routing ipv6 interface vrf X" for RFC5549 #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in VRF * Change documentation templates to render ip routing ipv6 interfaces in ip routing section
…s for rfc 5549 * Remove generating `ip routing` when `ip routing ipv6 interfaces` is True
@onurgashi please take a look at this as a starting point |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Mar 27, 2023
ClausHolbechArista
requested changes
Mar 28, 2023
ansible_collections/arista/avd/examples/campus-fabric/documentation/devices/LEAF1A.md
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/examples/single-dc-l3ls/intended/structured_configs/dc1-leaf1b.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/vrfs.py
Outdated
Show resolved
Hide resolved
* Fix check in `eos_designs` to ALSO check for overlay_rfc5549 * Change documentation template
..._collections/arista/avd/molecule/eos_cli_config_gen_v4.0/documentation/devices/ip-routing.md
Outdated
Show resolved
Hide resolved
...tions/arista/avd/molecule/evpn_underlay_rfc5549_overlay_ebgp/intended/configs/DC1-SPINE1.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-routing.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-routing.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-routing.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Mar 31, 2023
carlbuchmann
added
cherry-pick-for-3.8.x
PR to be cherry-picked to releases/v3.8.x brach later
type: bug
Something isn't working
labels
Mar 31, 2023
carlbuchmann
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
changed the title
Feat(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549
Fix(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549
Mar 31, 2023
gmuloc
changed the title
Fix(eos_designs,eos_cli_config_gen): Configure "ip routing ipv6 interface vrf X" for RFC5549
Fix(eos_designs): Configure "ip routing ipv6 interface vrf X" for RFC5549
Mar 31, 2023
carlbuchmann
added a commit
to carlbuchmann/avd
that referenced
this pull request
Apr 14, 2023
…face vrf X" for RFC5549 (aristanetworks#2660) Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
carlbuchmann
removed
the
cherry-pick-for-3.8.x
PR to be cherry-picked to releases/v3.8.x brach later
label
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Fix(eos_designs)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Renders correctly the
ip routing ipv6 interfaces vrf X
config for RFC5549 VRFs as reported in the linked issue.Add support for it in
eos_cli_config_gen
and fix documentation and a couple of issues.Related Issue(s)
Fixes #2646
Component(s) name
arista.avd.eos_designs
arista.avd.eos_cli_config_gen
Proposed changes
ip routing ipv6 interfaces vrf X
knob to eos_cli_config_geneos_cli_config_gen
documentation templates to show the information forip routing ipv6 interfaces
ipv6 unicast-routing vrf default
which is converted toipv6 unicast-routing
ip routing
whenip routing ipv6 interfaces
is configured in eos_designsip routing ipv6 interfaces vrf X
in VRF where it is required based on the underlay/overlat RFC5549 variables fromeos_designs
How to test
molecule scenario and particularly the evpn_underlay_rfc5549_overlay_ebgp one
Checklist
Repository Checklist