Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for TerminAttr token-secure auth for on-premise CV #2685

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add support for TerminAttr token-secure auth for on-premise CV

Related Issue(s)

Fixes #2025

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Sneaking a few fixes for porting guide in here

  • Changing behavior if ingestkey is not set, to instead configure token auth.
    This is non breaking for any deployments, since they would have the key set already.
    CV will deprecate support for key based auth soon, so we need to move people towards
    cert based auth also for on-prem.

    On-premise CVP ingest auth key. If set, terminattr will be configured with key-based authentication for on-premise CVP.
    If not set, terminattr will be configured with certificate based authentication using token-secure onboarding.
    Token must be copied to the device first.

How to test

Added molecule test without key.
No changes to other molecule scenarios having keys set.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner April 1, 2023 18:19
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation labels Apr 1, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos designs): Add support for TerminAttr token-secure auth for on-premise CV Feat(eos_designs): Add support for TerminAttr token-secure auth for on-premise CV Apr 1, 2023
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment about making terminattr -> TerminAttr for comments / descriptions to be consistent with some other buts of the doc (in the schema as well)

@gmuloc gmuloc requested a review from a team April 3, 2023 12:14
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/terminattr-token-auth-for-onprem branch from 40f5a51 to eb0baf3 Compare April 4, 2023 07:26
@ClausHolbechArista ClausHolbechArista merged commit 53d8977 into aristanetworks:devel Apr 4, 2023
31 checks passed
@noredistribution
Copy link
Contributor

one quick comment here, token-secure method is only supported on CVaaS, whereas on on-prem it has to be token
they are essentially the same mechanism but token-secure will only work on CVaaS and token will only work on on-prem, so we will have to make sure to use "method": "token" unless CVaaS is used in which case it's `"method": "token-secure"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add support for Terminattr token/cert based auth
4 participants