-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for TerminAttr token-secure auth for on-premise CV #2685
Feat(eos_designs): Add support for TerminAttr token-secure auth for on-premise CV #2685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comment about making terminattr -> TerminAttr for comments / descriptions to be consistent with some other buts of the doc (in the schema as well)
ansible_collections/arista/avd/roles/eos_designs/docs/Management Settings.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nt Settings.md Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
40f5a51
to
eb0baf3
Compare
one quick comment here, |
Change Summary
Add support for TerminAttr token-secure auth for on-premise CV
Related Issue(s)
Fixes #2025
Component(s) name
arista.avd.eos_designs
Proposed changes
Sneaking a few fixes for porting guide in here
Changing behavior if ingestkey is not set, to instead configure token auth.
This is non breaking for any deployments, since they would have the key set already.
CV will deprecate support for key based auth soon, so we need to move people towards
cert based auth also for on-prem.
How to test
Added molecule test without key.
No changes to other molecule scenarios having keys set.
Checklist
User Checklist
Repository Checklist