Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Checks for missing "vlans" key on access port-channel #2701

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix(eos_cli_config_gen): Checks for missing "vlans" key on access port-channel #2701

merged 1 commit into from
Apr 5, 2023

Conversation

jonxstill
Copy link
Contributor

Change Summary

A port-channel interface in mode access in structured_config with no vlans will cause a failure:

fatal: [mls00126 -> localhost]: FAILED! => 
  msg: '''dict object'' has no attribute ''vlans''. ''dict object'' has no attribute ''vlans'''

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Simple check for key before using it.

How to test

Molecule test cases added to molecule for both access and trunk port-channels.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@jonxstill jonxstill requested a review from a team as a code owner April 5, 2023 11:08
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Apr 5, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team April 5, 2023 11:33
@gmuloc gmuloc merged commit 331f68d into aristanetworks:devel Apr 5, 2023
32 checks passed
@carlbuchmann carlbuchmann added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Apr 6, 2023
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Apr 14, 2023
@jonxstill @carlbuchmann
Fix(eos_cli_config_gen): Checks for missing "vlans" key on access por…
591293c 
…t-channel (aristanetworks#2701)
@carlbuchmann carlbuchmann mentioned this pull request Apr 14, 2023
Merged
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Apr 14, 2023
carlbuchmann added a commit that referenced this pull request Apr 14, 2023
@carlbuchmann @jonxstill @ClausHolbechArista
Fix(eos_cli_config_gen): Checks for missing "vlans" key on access por…
d9dc88d 
…t-channel (#2701) (#2731)

Co-authored-by: Jon Still <jonstill@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
@jonxstill jonxstill deleted the eos_cli_config_gen_no_vlans branch December 7, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@jonxstill jonxstill

Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonxstill @gmuloc @ClausHolbechArista @carlbuchmann