Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Add support for her and cvx in default_overlay_routing_protocol #2717

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Fix(eos_designs): Add support for her and cvx in default_overlay_routing_protocol #2717

merged 2 commits into from
Apr 11, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Apr 11, 2023

Change Summary

Related Issue(s)

Fixes #2713

Component(s) name

arista.avd.eos_designs

Proposed changes

Add support for her and cvx for the key default_overlay_routing_protocol

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner April 11, 2023 09:14
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 11, 2023
@gmuloc gmuloc added this to the v4.0.0-dev10 milestone Apr 11, 2023
ClausHolbechArista
ClausHolbechArista approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one place where a $ref would help a lot.

@ClausHolbechArista ClausHolbechArista requested a review from a team April 11, 2023 10:04
carlbuchmann
carlbuchmann approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 89f726c into aristanetworks:devel Apr 11, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev10
Development

Successfully merging this pull request may close these issues.

Schema for node_type_keys.default_overlay_protocols is not correct
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista