-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add global IP NAT support #2747
Conversation
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ip-nat.md
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ip-nat.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ip-nat.md
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_nat.schema.yml
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_nat.schema.yml
Show resolved
Hide resolved
- Respect blank lines before/after headings - List NAT pools as headings - Use tables for settings - Inlcude EOS device configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kornoa for the PR and the updates after @ClausHolbechArista comments!
Added a couple of my own - some of them more for discussions than changes really.
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_nat.schema.yml
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/ip_nat.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-nat.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-nat.j2
Outdated
Show resolved
Hide resolved
- Added descriptions - Removed obsolete type conversion
- Split global IP NAT config into two sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this significant contribution!
Change Summary
Adding support to render IP NAT global EOS configuration.
Related Issue(s)
Fixes #2724
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
added
ip_nat
How to test
structured config:
result in EOS CLI config:
Checklist
User Checklist
Repository Checklist