Feat(eos_designs): update PTP syntax "enable" -> "enabled" #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_designs
nielsjlarsen
force-pushed
the
2366-feateos_cli_config_gen-eos_designs-update-ptp-syntax-from-enable-to-enabled
branch
from
cd2f652
to
090c3af
Compare
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml
Show resolved
Hide resolved
gmuloc
changed the title
nielsjlarsen
force-pushed
the
2366-feateos_cli_config_gen-eos_designs-update-ptp-syntax-from-enable-to-enabled
branch
from
e28d24f
to
c08280d
Compare
ansible_collections/arista/avd/roles/eos_designs/python_modules/l3_edge/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/core_interfaces/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_p2p_links.schema.yml
Show resolved
Hide resolved
…s/l3_edge/utils.py Co-authored-by: Claus Holbech <holbech@arista.com>
…s/core_interfaces/utils.py Co-authored-by: Claus Holbech <holbech@arista.com>
nielsjlarsen
force-pushed
the
2366-feateos_cli_config_gen-eos_designs-update-ptp-syntax-from-enable-to-enabled
branch
from
e60ebff
to
250f28b
Compare
gmuloc
reviewed
May 9, 2023
ansible_collections/arista/avd/roles/eos_designs/docs/L3 Edge.md
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
May 9, 2023
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_p2p_links.schema.yml
Outdated
Show resolved
Hide resolved
…ate-ptp-syntax-from-enable-to-enabled
…ate-ptp-syntax-from-enable-to-enabled
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ate-ptp-syntax-from-enable-to-enabled
ClausHolbechArista
approved these changes
May 15, 2023
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Changes PTP syntax from "ptp_enable" or "enable" to "enabled" to ensure syntax consistency throughout the various places of PTP configuration.
Related Issue(s)
Fixes #2366
Component(s) name
arista.avd.eos_designsProposed changes
Updated documentation
Updated Release Notes
Updated Porting Guides
Updated Molecule
Added use of port_profiles to Molecule
Updated use of PTP priority in Molecule to avoid confusion based on test topology
Updated l3_edge
Updated core_interfaces
Updated schemas
How to test
molecule converge -s eos_designs_unit_tests
Checklist
User Checklist
Repository Checklist