Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add ethernet_interfaces logging event options #2783

Merged
merged 3 commits into from
May 8, 2023

Conversation

kornoa
Copy link
Contributor

@kornoa kornoa commented May 3, 2023

Change Summary

EOS CLI offers four options for logging event under ethernet interface.

access(config-if-Et20)#no logging event ?
  congestion-drops  Drops due to congestion
  link-status       UPDOWN messages
  spanning-tree     Spanning tree messages
  storm-control     Configure storm-control

Two of them were missing in AVD: spanning-tree and storm-control

Related Issue(s)

Fixes #2781

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adjusted data model:

ethernet_interfaces:
  - logging:
      event:
        link_status: <bool>
        congestion_drops: <bool>
        spanning_tree: <bool>
        storm_control: <bool>

How to test

Adjusted molecule tests for eos_cli_config_gen scenario:

  - name: Ethernet6
    logging:
      event:
        link_status: true
        congestion_drops: true
        spanning_tree: true
        storm_control: true

  - name: Ethernet13
    logging:
      event:
        link_status: false
        congestion_drops: false
        spanning_tree: false
        storm_control: false

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@kornoa kornoa requested a review from a team as a code owner May 3, 2023 09:26
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 3, 2023
@gmuloc gmuloc requested a review from a team May 3, 2023 12:14
@gmuloc
Copy link
Contributor

gmuloc commented May 3, 2023

Failing CI on mkdoc is due to some other issue so can be ignore here.

@ClausHolbechArista ClausHolbechArista merged commit a4d2395 into aristanetworks:devel May 8, 2023
35 checks passed
@kornoa kornoa deleted the eth_logging_event branch May 8, 2023 08:29
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Add ethernet IF logging event options Feat(eos_cli_config_gen): Add ethernet_interfaces logging event options May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): add missing options to ethernet logging event configuration
3 participants