Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs)!: fabric variable for bgp default ipv4 unicast #2799

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented May 8, 2023

Change Summary

Add fabric variable for bgp default ipv4 unicast, and enforce best practice (disable)

  • updated documentation to remove references in bgp_defaults:

Related Issue(s)

fixes aristanetworks/avd-internal#100

Component(s) name

arista.avd.eos_designs

Proposed changes

bgp_default_ipv4_unicast: <bool> -> default false

How to test

See molecule test results

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation labels May 8, 2023
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release-notes and porting guide.

@carlbuchmann carlbuchmann force-pushed the feat-eos-designs-bgp-default-ipv4-unicast branch from 2126d82 to a1cf067 Compare May 11, 2023 20:30
@carlbuchmann carlbuchmann marked this pull request as ready for review May 12, 2023 00:20
@carlbuchmann carlbuchmann requested a review from a team as a code owner May 12, 2023 00:20
@carlbuchmann carlbuchmann merged commit 779e838 into aristanetworks:devel May 12, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants