Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Change authentication method and token path for on-prem token auth #2800

Merged
merged 3 commits into from
May 10, 2023
Merged

Fix(eos_designs): Change authentication method and token path for on-prem token auth #2800

merged 3 commits into from
May 10, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Change authentication method and token path for on-prem token auth

Related Issue(s)

Fixes #2700

Component(s) name

arista.avd.eos_designs

Proposed changes

Fix defaults according to best practices. Not breaking since feature was implemented during 4.0.0 development.

How to test

Updated molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 8, 2023 06:50
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_ddesigns): Change authentication method and token path for on-prem token auth Fix(eos_designs): Change authentication method and token path for on-prem token auth May 8, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 8, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-dev12 milestone May 8, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request May 8, 2023
Merged
4 tasks
@gmuloc gmuloc requested a review from a team May 9, 2023 08:21
@ClausHolbechArista
Copy link
Contributor Author

got ok from @noredistribution offline. So I will merge this.

@ClausHolbechArista ClausHolbechArista merged commit 1793abb into aristanetworks:devel May 10, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@noredistribution noredistribution Awaiting requested review from noredistribution

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-dev12
Development

Successfully merging this pull request may close these issues.

Fixes needed for token auth implemented in #2685
2 participants
@ClausHolbechArista @gmuloc