Feat(eos_cli_config_gen): Flow tracking table size #2838
Conversation
Adds functionality to specify the flow tracking table size.
github-actions
bot
added
role: eos_cli_config_gen
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Adds functionality to specify the flow tracking table size.
hamptonmoore
force-pushed
the
add_ipfix_table_size
branch
from
75c3b13
to
9c210c6
Compare
| type: int | ||
| convert_types: | ||
| - str | ||
| min: 1 |
There was a problem hiding this comment.
if we know the maximum value, please set it.
There was a problem hiding this comment.
Maximum depends on the platform. I have not found documentation of a definite upper limit, but on the platforms I tested, the minimum was always 1, hence why I defined a minimum but no max.
There was a problem hiding this comment.
Can we add a max at 614400 (cf internal discussion with link to eos-trunk model) and add in the description that the max is platform dependent ?
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/flow_trackings.schema.yml
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/flow-trackings.j2
Outdated
Show resolved
Hide resolved
…s/schema_fragments/flow_trackings.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…tes/documentation/flow-trackings.j2 Co-authored-by: Claus Holbech <holbech@arista.com>
…sible-avd into add_ipfix_table_size
| @@ -12,6 +12,8 @@ flow_trackings: | |||
| mpls: true | |||
| # no exporter | |||
| - name: T2 | |||
| # table size as string | |||
| table_size: "999999" | |||
There was a problem hiding this comment.
I have read the close comments about the upper limit being platform dependent.
However can we use in the molecule test some values that would be accepted on vEOS / cEOS in case we start trying the configs on such devices:
vEOS 4.27.0F output:
Spine1(config-ftr-sampled-tr-T2)#flow table size ?
<1-614400> Maximum number of entries in flow table
| type: int | ||
| convert_types: | ||
| - str | ||
| min: 1 |
There was a problem hiding this comment.
Can we add a max at 614400 (cf internal discussion with link to eos-trunk model) and add in the description that the max is platform dependent ?
Adds functionality to specify the flow tracking table size.
Change Summary
At the moment, specifying the flow tracking table size for a flow tracker is cumbersome as it requires using
eos_cliand specifying the context commands to get to the flow tracker context.This PR makes it easy to specify the optional table size.
Related Issue(s)
No Tickets currently raised for this.
Component(s) name
arista.avd.eos_cli_conifg_genProposed changes
How to test
molecule test -s eos_cli_config_genChecklist
User Checklist
Repository Checklist