Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs)!: Change p2p_uplinks_mtu default value from 9000 to 9214 #2844

Merged
merged 2 commits into from
May 17, 2023

Conversation

carlbuchmann
Copy link
Member

Change Summary

Change p2p_uplinks_mtu default value from 9000 to 9214

Related Issue(s)

Fixes #aristanetworks/avd-internal#101

Component(s) name

arista.avd.eos_designs

Proposed changes

Change p2p_uplinks_mtu default value from 9000 to 9214
updated release notes and porting guide
update molecule scenarios

How to test

Verify CI passes and molecule scenarios updated.

@carlbuchmann carlbuchmann added this to the v4.0.0-rc1 milestone May 16, 2023
@carlbuchmann carlbuchmann requested a review from a team as a code owner May 16, 2023 15:12
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation labels May 16, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team May 16, 2023 16:50
@emilarista emilarista self-assigned this May 17, 2023
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed. LGTM!

@carlbuchmann carlbuchmann merged commit d2e86de into aristanetworks:devel May 17, 2023
32 checks passed
@PhirePhly
Copy link
Contributor

PhirePhly commented Mar 25, 2024

Shame on me for not being more careful, but I'll note for the record that this change caused a customer impacting outage on the FCIX upgrade from 3 to 4 by taking the OSPF underlay down, so hopefully we don't ever change this value again without an extremely good reason. It's called out in the porting guide and everything, so this is just me not being able to read.

@ClausHolbechArista
Copy link
Contributor

Please review the release notes and porting guide. They mention all the breaking changes, and how to work around them. Sorry to hear about the outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants