Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs)!: Remove default value from mlag_peer_link_allowed_vlans #2845

Merged

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented May 16, 2023

Change Summary

Remove default value from mlag_peer_link_allowed_vlans of "2-4094".

This was a historical setting, never aligned with Arista's best practices!

Related Issue(s)

Fixes #aristanetworks/avd-internal#102

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Remove default value from mlag_peer_link_allowed_vlans
  • Update release notes and porting guide
  • Update molecule scenarios

How to test

See molecule results

@carlbuchmann carlbuchmann requested a review from a team as a code owner May 16, 2023 15:36
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation labels May 16, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team May 16, 2023 16:54
@carlbuchmann carlbuchmann added this to the v4.0.0-rc1 milestone May 16, 2023
Copy link
Contributor

@chetryan chetryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - Would be nice to add a comment or update the PR description with why it is a good idea to remove this default value.

@carlbuchmann carlbuchmann merged commit cef23b8 into aristanetworks:devel May 17, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants