Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Make BFD configurable under bgp_peer_groups #2890

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Make BFD configurable under bgp_peer_groups

Component(s) name

arista.avd.eos_designs

Proposed changes

    bgp_peer_groups:
      ipv4_underlay_peers:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      mlag_ipv4_underlay_peer:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      evpn_overlay_peers:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      evpn_overlay_core:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      mpls_overlay_peers:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      rr_overlay_peers:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>
      ipvpn_gateway_peers:
        name: <str>
        password: <str>
        bfd: <bool>
        structured_config: <dict>

How to test

  • Renamed existing molecule tests for BGP_PEER_GROUPS_STRUCTURED_CONFIG to BGP_PEER_GROUPS and added the bfd key with the opposite of the default value for all peer-groups.
  • Verified updated outputs
  • No unexpected changes.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 24, 2023 14:47
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 24, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.1.0 milestone May 24, 2023
@ClausHolbechArista ClausHolbechArista added this to To Do in DK-PROJECT-02 via automation May 24, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@skanagal skanagal self-requested a review June 5, 2023 13:48
@carlbuchmann carlbuchmann force-pushed the fix/eos_designs/bfd-bgp_peer_groups branch from a1e1699 to d61ba5c Compare June 14, 2023 01:19
@carlbuchmann carlbuchmann removed the state: conflict PR with conflict label Jun 14, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed test results.

Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed docs, LGTM!

@carlbuchmann carlbuchmann merged commit 476067b into aristanetworks:devel Jun 15, 2023
31 checks passed
DK-PROJECT-02 automation moved this from To Do to Done Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
DK-PROJECT-02
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants