Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): bgp_mesh_pes #2899

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix(eos_designs): bgp_mesh_pes #2899

merged 1 commit into from
May 29, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix bgp_mesh_pes

Related Issue(s)

Fixes #2843

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Fix typo in code
  • Update docs to reflect that it only works in combination with MPLS overlay
  • Add test case

How to test

  • Added test case.
  • No other changes.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 26, 2023 09:28
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 26, 2023
@ClausHolbechArista ClausHolbechArista added this to the v4.0.0-rc2 milestone May 26, 2023
carlbuchmann
carlbuchmann approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label May 29, 2023
@carlbuchmann carlbuchmann merged commit cf85c97 into aristanetworks:devel May 29, 2023
31 checks passed
@carlbuchmann carlbuchmann removed the cherry-pick-for-3.8.x PR to be cherry-picked to releases/v3.8.x brach later label Jul 13, 2023
@carlbuchmann carlbuchmann mentioned this pull request Jul 13, 2023
Merged
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Jul 13, 2023
@ClausHolbechArista @carlbuchmann
Fix(eos_designs): bgp_mesh_pes (aristanetworks#2899)
b541e0d
gmuloc pushed a commit that referenced this pull request Jul 20, 2023
@carlbuchmann @ClausHolbechArista
Fix(eos_designs): bgp_mesh_pes (#2899) (#3038)
a4be05b 
Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@emilarista emilarista Awaiting requested review from emilarista

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v4.0.0-rc2
Development

Successfully merging this pull request may close these issues.

Fix(eos_designs): bgp_mesh_pes doesn't generate any BGP configutation
2 participants
@ClausHolbechArista @carlbuchmann