Fix(eos_designs): eBGP rfc5549 creates invalid configuration for MLAG scenarios

[carlbuchmann]

Change Summary

Fix issues in the eBGP rfc5549 design with MLAG configuration scenario as described in #2906

Related Issue(s)

Fixes #2906

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

If underlay_rfc5549 is True and overlay_mlag_rfc5549 is True configure:

ipv6 unicast-routing vrf <vrf_name>

If underlay_rfc5549 is True and overlay_mlag_rfc5549 is False configure:

router_bgp <asn>
   vrf <vrf_name>
      address-family ipv4
         no neighbor <mlag-peer-ip> next-hop address-family ipv6

How to test

Run Molecule scenario: molecule converge -s evpn_underlay_rfc5549_overlay_ebgp

Checklist

User Checklist

• Update test case for evpn_underlay_rfc5549_overlay_ebgp
• Fix underlay_rfc5549 is True and overlay_mlag_rfc5549 is True
• Add eos_cli_config_gen knob for router_bgp.vrfs.address_family_ipv4."no neighbor <ip_address> next-hop address-family ipv6"
• Fix If underlay_rfc5549 is True and overlay_mlag_rfc5549 is False

[ClausHolbechArista]

Tested in lab where the issue was recreated, and these fixes work for both cases.

[carlbuchmann]

@ClausHolbechArista thank you - LGTM, added unit tests for eos_cli_config_gen

[onurgashi]

LGTM! Thanks for fixing this.