-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs, eos_cli_config_gen): BGP VRF peer group options, global context ipv6 multicast and flowspec #2976
Refactor(eos_designs, eos_cli_config_gen): BGP VRF peer group options, global context ipv6 multicast and flowspec #2976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some schema comments. Written in free-hand, so please verify that the models are correct. Please keep the required: true
on the enabled
key.
Please add release-notes and porting-guide details.
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
…s/schema_fragments/router_bgp.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…s/schema_fragments/router_bgp.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
...sta/avd/molecule/eos_cli_config_gen_deprecated_vars/inventory/host_vars/host1/router-bgp.yml
Show resolved
Hide resolved
…recated_vars/inventory/host_vars/host1/router-bgp.yml Co-authored-by: Claus Holbech <holbech@arista.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
This PR is refactoring peer group configuration under VRF mode in BGP. Since all the configurable options for peer groups under VRF submode get pushed out to the global mode, these options have been moved to the global BGP context where applicable.
New multicast ipv6 and flow-spec AFs have been implemented in the global context since there was an indirect way to configure them via the VRF submodes with the old (now deprecated) vrf.address_families data model.
Also featuring an update to router_bgp.address_family_ipv4.neighbor..next_hop.address_family_ipv6_originate data model to add an option for enabling it without the "originate" keyword which is also supported in EOS.
Component(s) name
arista.avd.eos_cli_config_gen
arista.avd.eos_designs
Proposed changes
How to test
Expanded molecule to test the new knobs.
Repository Checklist