-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): add support for password complexity policies #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jun 16, 2023
hamptonmoore
force-pushed
the
password_policy
branch
from
June 16, 2023 18:09
5dd30ae
to
81d257d
Compare
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml
Show resolved
Hide resolved
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml
Outdated
Show resolved
Hide resolved
hamptonmoore
force-pushed
the
password_policy
branch
from
June 17, 2023 20:12
5bf3cc4
to
c230190
Compare
carlbuchmann
requested changes
Jun 19, 2023
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml
Show resolved
Hide resolved
carlbuchmann
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hamptonmoore
force-pushed
the
password_policy
branch
from
June 21, 2023 14:54
4913e98
to
40bb635
Compare
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/management-security.md
Outdated
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/management-security.md
Outdated
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/management-security.md
Show resolved
Hide resolved
.../arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/management_security.schema.yml
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-security.j2
Outdated
Show resolved
Hide resolved
Moving this to draft until, review comments have been addressed. |
github-actions
bot
added
type: documentation
Improvements or additions to documentation
role: eos_designs
issue related to eos_designs role
labels
Jul 3, 2023
hamptonmoore
force-pushed
the
password_policy
branch
from
July 3, 2023 21:06
72341d2
to
765be16
Compare
github-actions
bot
removed
type: documentation
Improvements or additions to documentation
role: eos_designs
issue related to eos_designs role
labels
Jul 3, 2023
hamptonmoore
force-pushed
the
password_policy
branch
from
July 6, 2023 16:57
765be16
to
67efbaa
Compare
hamptonmoore
force-pushed
the
password_policy
branch
from
July 21, 2023 15:37
67efbaa
to
334d59b
Compare
JulioPDX
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for the password complexity policies introduced into EOS 4.29.2F (https://www.arista.com/en/support/toi/eos-4-29-2f/17208-support-for-password-complexity-policies)
Related Issue(s)
Fixes #2972
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add policy list key to management_security.password with all the relevant options exposed in EOS CLI
Add ability to set policy used via management_accounts
How to test
Checklist
User Checklist
Repository Checklist