Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): add support for password complexity policies #2991

Merged
merged 9 commits into from
Jul 21, 2023

Conversation

hamptonmoore
Copy link
Member

@hamptonmoore hamptonmoore commented Jun 16, 2023

Change Summary

Add support for the password complexity policies introduced into EOS 4.29.2F (https://www.arista.com/en/support/toi/eos-4-29-2f/17208-support-for-password-complexity-policies)

Related Issue(s)

Fixes #2972

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add policy list key to management_security.password with all the relevant options exposed in EOS CLI
Add ability to set policy used via management_accounts

How to test

  • run molecule test -s eos_cli_config_gen

Checklist

User Checklist

  • Implement management_security.password schema and generation
  • Implement management_accounts
  • Add/update relevant documentation templates
  • Review the new Documentation

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 16, 2023
@hamptonmoore hamptonmoore marked this pull request as ready for review June 17, 2023 20:39
@hamptonmoore hamptonmoore requested review from a team as code owners June 17, 2023 20:39
carlbuchmann

This comment was marked as outdated.

@carlbuchmann carlbuchmann requested review from a team and carlbuchmann June 19, 2023 14:50
@carlbuchmann carlbuchmann dismissed their stale review June 19, 2023 14:53

one more correction I noticed

@carlbuchmann carlbuchmann requested a review from a team June 20, 2023 18:55
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista
Copy link
Contributor

Moving this to draft until, review comments have been addressed.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft July 3, 2023 06:55
@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_designs issue related to eos_designs role labels Jul 3, 2023
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation role: eos_designs issue related to eos_designs role labels Jul 3, 2023
@hamptonmoore hamptonmoore marked this pull request as ready for review July 5, 2023 18:22
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@JulioPDX JulioPDX merged commit 9abeed5 into aristanetworks:devel Jul 21, 2023
35 checks passed
@hamptonmoore hamptonmoore deleted the password_policy branch July 21, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVD support for password complexity policies
4 participants