Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Adding structured_config to l3_edge P2P_links #3017

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Feat(eos_designs): Adding structured_config to l3_edge P2P_links #3017

merged 4 commits into from
Jul 10, 2023

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Jul 3, 2023 •
edited by ClausHolbechArista

Change Summary

Adding structured_config to l3_edge P2P_links

Related Issue(s)

Fixes #2840

Component(s) name

arista.avd.eos_designs

Proposed changes

Explained in the issue description

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested review from a team as code owners July 3, 2023 11:12
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft July 3, 2023 11:12
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 3, 2023
@Shivani-chourasiya Shivani-chourasiya marked this pull request as ready for review July 3, 2023 12:53
@ClausHolbechArista ClausHolbechArista requested a review from a team July 6, 2023 05:49
gmuloc
gmuloc approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 36608bc into aristanetworks:devel Jul 10, 2023
32 checks passed
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees
No one assigned
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: structured_config on p2p_links
4 participants
@Shivani-chourasiya @gmuloc @ClausHolbechArista @Shivani-gslab