Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix router_isis.instance schema #3050

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jul 19, 2023

Change Summary

router_isis.instance is a Required knob but the Required field is not set in the schema. This is fixed in this PR.

Related Issue(s)

Fixes #3049

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested review from a team as code owners July 19, 2023 20:17
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jul 19, 2023
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this

@gmuloc gmuloc requested review from a team July 20, 2023 08:47
@tgodaA
Copy link
Contributor Author

tgodaA commented Jul 20, 2023

It's been months now since I have contributed my last PR.

@ClausHolbechArista ClausHolbechArista merged commit 5c4624d into aristanetworks:devel Jul 24, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix(eos_cli_config_gen): Fix the router_isis schema and documentation
3 participants