Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for setting source-interfaces for management protocols #3072

Merged
merged 13 commits into from
Aug 24, 2023
Merged

Feat(eos_designs): Add support for setting source-interfaces for management protocols #3072

merged 13 commits into from
Aug 24, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Aug 1, 2023 •
edited

Change Summary

Add support for setting source-interfaces for management protocols

Related Issue(s)

Part of #1539
Part of #2631

Component(s) name

arista.avd.eos_designs

Proposed changes

source_interfaces:
  domain_lookup:
    mgmt_interface: <bool>
    inband_mgmt_interface: <bool>
  http_client:
    mgmt_interface: <bool>
    inband_mgmt_interface: <bool>
  radius:
    mgmt_interface: <bool>
    inband_mgmt_interface: <bool>
  ssh_client:
    mgmt_interface: <bool>
    inband_mgmt_interface: <bool>
  tacacs:
    mgmt_interface: <bool>
    inband_mgmt_interface: <bool>

How to test

Molecule incl. negative test cases.

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Aug 1, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Aug 8, 2023
Merged
4 tasks
@ClausHolbechArista ClausHolbechArista mentioned this pull request Aug 10, 2023
Merged
4 tasks
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review August 10, 2023 11:50
@carlbuchmann carlbuchmann self-requested a review August 11, 2023 00:29
@ClausHolbechArista ClausHolbechArista marked this pull request as draft August 11, 2023 14:17
tgodaA
tgodaA previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we add the same schema for snmp-server, ntp and logging?

@tgodaA tgodaA dismissed their stale review August 14, 2023 01:10

Since this is in Draft I am cancelling my approval. Approved it by mistake.

@ClausHolbechArista
Copy link
Contributor Author

LGTM

Can we add the same schema for snmp-server, ntp and logging?

They will be added in seperate PRs together with more options for each protocol being exposed in eos_designs, to ensure we can pick up the VRFs dynamically from the configured management VRF, Interface and IP settings.

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Aug 14, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review August 14, 2023 07:52
@ClausHolbechArista
Copy link
Contributor Author

@tgodaA the PR is ready for review now. Just needed to adjust a few things after rebase.

@ClausHolbechArista ClausHolbechArista requested review from tgodaA and a team August 16, 2023 08:16
@ClausHolbechArista ClausHolbechArista requested review from tgodaA and a team August 24, 2023 07:03
tgodaA
tgodaA approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 5bfdab1 into aristanetworks:devel Aug 24, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClausHolbechArista @tgodaA