Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add default_interface_mtu and feature_support.per_interface_mtu #3128

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Feat(eos_designs): Add default_interface_mtu and feature_support.per_interface_mtu #3128

merged 6 commits into from
Sep 12, 2023

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add default_interface_mtu and feature_support.per_interface_mtu

Related Issue(s)

Related to #3123 but not changing the default settings.

Component(s) name

arista.avd.eos_designs

Proposed changes

platform_settings:
  - ...
    default_interface_mtu: <int>
    feature_support:
      per_interface_mtu: <bool>

How to test

Added molecule coverage.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 7, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Sep 7, 2023
Open
@ClausHolbechArista
Copy link
Contributor Author

Thank you to @kmueller68 for testing this. See #3123 for details.

carlbuchmann
carlbuchmann approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann force-pushed the feat/eos_designs/support-default-interface-mtu branch from 3f9dabe to e162bdb Compare September 9, 2023 01:09
@ClausHolbechArista ClausHolbechArista requested a review from a team September 11, 2023 05:59
carlbuchmann and others added 2 commits September 11, 2023 20:58
@carlbuchmann @gmuloc
Update ansible_collections/arista/avd/roles/eos_designs/schemas/schem…
853e0b0 
…a_fragments/platform_settings.schema.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carlbuchmann
update schemas
d0bf11b
@gmuloc gmuloc merged commit b9562aa into aristanetworks:devel Sep 12, 2023
34 checks passed
@kmueller68 kmueller68 mentioned this pull request Apr 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClausHolbechArista @gmuloc @carlbuchmann