Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support path-selection bgp address-family #3151

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Feat(eos_cli_config_gen): Support path-selection bgp address-family #3151

merged 2 commits into from
Oct 12, 2023

Conversation

burnyd
Copy link
Contributor

@burnyd burnyd commented Sep 19, 2023 •
edited by gmuloc

Change Summary

For WAN and AutoVPN need to add the path-selection address family.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add to the documentation and template for router bgp as well as some of the schema to add a new address-family.

EOS 4.30.1.F

leaf1(config-router-bgp-af)#show cli command
APPEND [ COMMENT ]
[no|default] bgp additional-paths receive
[no|default] bgp additional-paths send ( any | backup | ( [ ecmp ] [ limit LIMIT ] ) )
[...]
[no|default] neighbor ( GROUP | IP_PEER | IP6_PEER | IP6_LL_PEER ) ( activate | deactivate )
[no|default] neighbor ( GROUP | IP_PEER | IP6_PEER | IP6_LL_PEER ) additional-paths receive [ disabled ]
[no|default] neighbor ( GROUP | IP_PEER | IP6_PEER | IP6_LL_PEER ) additional-paths send ( ( any [ ( prefix-list PREFIX_LIST_NAME ) | disabled ] ) | ( ( backup | ( [ ecmp ] [ limit LIMIT ] ) ) [ prefi ...
[no|default] neighbor ( GROUP | IP_PEER | IP6_PEER | IP6_LL_PEER ) prefix-list ( PREFIX_LIST_NAME ( in | out ) ) | ( ( NED_IN | NED_OUT ) disabled )
[...]

NOTE"

on same version - despite what show cli command says:

leaf1(config-router-bgp-af)#neighbor toto prefix-list toto out
! neighbor prefix-list unsupported in path-selection address family

so probably best to leave out prefix-lists for now.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.

@burnyd burnyd requested review from a team as code owners September 19, 2023 15:35
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Sep 19, 2023
ClausHolbechArista
ClausHolbechArista reviewed Sep 20, 2023
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 20, 2023 08:24
@gmuloc gmuloc requested review from ClausHolbechArista and a team October 3, 2023 10:37
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 3, 2023
@gmuloc gmuloc marked this pull request as ready for review October 3, 2023 10:38
@gmuloc
Copy link
Contributor

gmuloc commented Oct 3, 2023

@ClausHolbechArista please have a look at the PR comments regarding prefix-lists the show cli commands state it is present (and you can enter it from CLI) but I get an error message on 4.30.1F when trying to configure it. Should we remove it?

@carlbuchmann carlbuchmann self-requested a review October 3, 2023 14:52
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc requested a review from a team October 10, 2023 13:20
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role and removed state: conflict PR with conflict labels Oct 10, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@burnyd @carlbuchmann
Adding route-path selection to bgp
ffe8194 
ran pre-commit tasks

Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>

Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>

Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>

Fix: Implement full schema for address-family path-selection

Refactor: Clean jinja templates + molecule

Refactor(eos_cli_config_gen): Remove prefix-list for path-selection AFI

Doc: Run molecule after rebase

Fix: Run pre-commit and molecule post rebase
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 11, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista requested a review from a team October 12, 2023 07:33
carlbuchmann
carlbuchmann approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 9d2baed into aristanetworks:devel Oct 12, 2023
39 checks passed
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc left review comments

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@burnyd burnyd

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@burnyd @gmuloc @carlbuchmann @ClausHolbechArista