Fix(eos_cli_config_gen): ip http client source interfaces cli not generated #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
role: eos_cli_config_gen
carlbuchmann
force-pushed
the
fix-ip-http-client-sources-interfaces
branch
from
0c610a2
to
fb86d90
Compare
carlbuchmann
force-pushed
the
fix-ip-http-client-sources-interfaces
branch
from
fb86d90
to
1f19faf
Compare
github-actions
bot
added
type: code quality
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Please remove the last commit and try again. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
state: conflict
Fixed merged conflicts from Github UI |
ClausHolbechArista
approved these changes
Oct 2, 2023
gmuloc
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ip http client source interfaces cli not generated due to the incorrect if statement.
This only occurred when
ip_http_client_source_interfaceswas the only ip-client-source-interfaces key defined.Component(s) name
arista.avd.eos_cli_config_genProposed changes
Fix the typo in the if statement.
How to test
All molecule tests pass.