Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add ip security #3194

Merged
merged 11 commits into from
Oct 12, 2023
Merged

Feat(eos_cli_config_gen): Add ip security #3194

merged 11 commits into from
Oct 12, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 3, 2023

Change Summary

Implement ip security

Related Issue(s)

Fixes #3193

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

TBC

How to test

molecule tests to be deployed

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Oct 3, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 3, 2023
@gmuloc gmuloc changed the title Feat(eos_cli_config_gen): Add schema for ip security Feat(eos_cli_config_gen): Add ip security Oct 3, 2023
@gmuloc gmuloc marked this pull request as ready for review October 3, 2023 16:03
@gmuloc gmuloc requested review from a team as code owners October 3, 2023 16:03
@gmuloc
Copy link
Contributor Author

gmuloc commented Oct 3, 2023

TODO: check if shared_key should have convert_dict if only int are given

@gmuloc gmuloc requested review from a team October 11, 2023 15:30
colinmacgiolla
colinmacgiolla approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@colinmacgiolla colinmacgiolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ClausHolbechArista ClausHolbechArista merged commit cefcc3f into aristanetworks:devel Oct 12, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmacgiolla colinmacgiolla colinmacgiolla approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Implement ip security for AutoVPN / WAN configuration
4 participants
@gmuloc @colinmacgiolla @ClausHolbechArista @carlbuchmann