Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Improve evpn_multicast error handling #3195

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

jonxstill
Copy link
Contributor

@jonxstill jonxstill commented Oct 3, 2023

Change Summary

Raise errors when evpn_l2_multicast or evpn_l3_multicast is defined but evpn_multicast is not.

Related Issue(s)

Fixes #3153

Component(s) name

arista.avd.eos_designs

Proposed changes

Raises AristaAvdError when EVPN L2/L3 multicast is enabled at the VLAN, VRF or Tenant level, but not globally.

How to test

Negative tests added to check error is triggered.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Oct 3, 2023
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 5, 2023
for evpn_peg in default(get(vrf, "evpn_l3_multicast.evpn_peg"), get(tenant, "evpn_l3_multicast.evpn_peg"), []):
if self.shared_utils.hostname in evpn_peg.get("nodes", [self.shared_utils.hostname]) and rps:
vrf["_evpn_l3_multicast_evpn_peg_transit"] = evpn_peg.get("transit")
break
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A large chunk of this will need to be refactored due to #3201 - but I'm happy to merge this one first and then I'll rework #3201.

@jonxstill jonxstill marked this pull request as ready for review October 5, 2023 16:32
@jonxstill jonxstill requested review from a team as code owners October 5, 2023 16:32
@ClausHolbechArista ClausHolbechArista requested review from a team October 6, 2023 09:23
@carlbuchmann carlbuchmann merged commit 9508a39 into aristanetworks:devel Oct 13, 2023
36 checks passed
@jonxstill jonxstill deleted the evpn_multicast_fixes branch October 13, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically set software-forwarding SFE when configuring EVPN multicast in tenants
4 participants