Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for qos map exp #3204

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

philippebureau
Copy link
Contributor

Change Summary

add knob in eos_cli_config_gen to configure qos map exp

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

adding a key under qos.map for exp field

Addition to qos.schema:

type: dict
  keys:
    qos:
      map:
          exp:
            type: list
            items:
              type: str
              description: |
                Example "0 to traffic-class 0"

How to test

See molecule test

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@philippebureau philippebureau requested review from a team as code owners October 4, 2023 20:39
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 4, 2023
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add qos map exp Feat(eos_cli_config_gen): Add support for qos map exp Oct 6, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 12, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role type: code quality CI and development toolset role: eos_validate_state role: eos_designs issue related to eos_designs role state: conflict PR with conflict and removed state: conflict PR with conflict labels Oct 12, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 12, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role and removed role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role type: code quality CI and development toolset role: eos_validate_state role: eos_designs issue related to eos_designs role labels Oct 12, 2023
@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Oct 13, 2023
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally

@ClausHolbechArista
Copy link
Contributor

@philippebureau I have fixed a couple of issues. The things with blank lines are old issues, but since we are touching the template I wanted to get it fixed here. You also had a copy/paste error for the if condition which would have been hard to catch later.

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
@ClausHolbechArista ClausHolbechArista merged commit 6c68782 into aristanetworks:devel Oct 18, 2023
39 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants