Fix(eos_designs): Configure evpn_ebgp_gateway_multihop for ipvpn_gateway EBGP peers

[ClausHolbechArista]

Change Summary

Configure evpn_ebgp_gateway_multihop for ipvpn_gateway EBGP peers

Related Issue(s)

Fixes #3181

Component(s) name

arista.avd.eos_designs

Proposed changes

• Detect if an ipvpn_gateway peer is EBGP and set ebgp-multihop to value of evpn_ebgp_gateway_multihop.
• Remove invalid check for ipvpn_gateway.local_as from regular MPLS peerings.
• Remove wrongfully committed test file from molecule.
• Add test coverage for both IBGP and EBGP cases for ipvpn_gateway.

How to test

Added new testcase and also validated updates to existing.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[ClausHolbechArista]

@dgonzalez85 could you please test this one?

[dgonzalez85]

@dgonzalez85 could you please test this one?

hey @ClausHolbechArista. I am having issues, just double checking in case im missing something:

Im using your branch and i see your commit:

commit 7683416f2635aeeaecc88dfd5a7058d37abf8f6f (HEAD -> fix/eos_designs/ebgp-multihop-for-ipvpn-gateway, origin/fix/eos_designs/ebgp-multihop-for-ipvpn-gateway)
Author: Claus Holbech <holbech@arista.com>
Date:   Thu Oct 5 10:18:06 2023 +0200

    Fix(eos_designs): Configure evpn_ebgp_gateway_multihop for ipvpn_gateway for ebgp peers.

In the fabric file i set this:

evpn_ebgp_gateway_multihop: 5

But i still do not see the multihop set:

   neighbor IPVPN-GATEWAY-PEERS peer group
   neighbor IPVPN-GATEWAY-PEERS update-source Loopback0
   neighbor IPVPN-GATEWAY-PEERS bfd
   neighbor IPVPN-GATEWAY-PEERS send-community
   neighbor IPVPN-GATEWAY-PEERS maximum-routes 0

[ClausHolbechArista]

But i still do not see the multihop set:

   neighbor IPVPN-GATEWAY-PEERS peer group
   neighbor IPVPN-GATEWAY-PEERS update-source Loopback0
   neighbor IPVPN-GATEWAY-PEERS bfd
   neighbor IPVPN-GATEWAY-PEERS send-community
   neighbor IPVPN-GATEWAY-PEERS maximum-routes 0

Check under the neighbor. We cannot set it on the peer group, since you could have a mix of IBGP and EBGP.

[emilarista]

Tested feature and reviewed code, LGTM!

[dgonzalez85]

But i still do not see the multihop set:

   neighbor IPVPN-GATEWAY-PEERS peer group
   neighbor IPVPN-GATEWAY-PEERS update-source Loopback0
   neighbor IPVPN-GATEWAY-PEERS bfd
   neighbor IPVPN-GATEWAY-PEERS send-community
   neighbor IPVPN-GATEWAY-PEERS maximum-routes 0

Check under the neighbor. We cannot set it on the peer group, since you could have a mix of IBGP and EBGP.

no luck, i still do not see it there. happy to show you my example over a call if you have time. otherwise if other folks say its working, thats fine, might be something wrong in my example test!

[dgonzalez85]

Tested and looking good