Fix(eos_validate_state): ANTA VerifyRoutingProtocolModel now only run if there is BGP configuration #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figuration and service_routing_protocols_model is set to multi-agent
github-actions
bot
added
role: eos_validate_state
state: CI Updated
ClausHolbechArista
changed the title
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestrouting.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestrouting.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
changed the title
ClausHolbechArista
approved these changes
Oct 10, 2023
gmuloc
reviewed
Oct 12, 2023
Comment on lines
163
to
165
| else: | ||
| LOGGER.warning("Variable 'service_routing_protocols_model' is NOT set to 'multi-agent'. %s is skipped.", self.__class__.__name__) | ||
| return None |
There was a problem hiding this comment.
Could invert if and else and return first
if service_routing_protocols_model != "multi-agent":
LOGGER.warning("Variable 'service_routing_protocols_model' is NOT set to 'multi-agent'. %s is skipped.", self.__class__.__name__)
return None
...
There was a problem hiding this comment.
Agreed. Fixed in 6fbead6
gmuloc
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
VerifyRoutingProtocolModel is now run only if there is a BGP configuration and
service_routing_protocols_modelis set to 'multi-agent' in the structured_config.Related Issue(s)
Fixes #3189
Component(s) name
arista.avd.eos_validate_statein ANTA ModeProposed changes
AvdTestBGP test definition is now added only if
router_bgpandservice_routing_protocols_modelexist andservice_routing_protocols_modelis set to 'multi-agent' in the structured_config.How to test
Tested with
eos_validate_statemolecule.VerifyRoutingProtocolModeltest is now removed from L2 leafs test catalog.Checklist
User Checklist
Repository Checklist