Feat(eos_cli_config_gen): Add 'router service-insertion' CLI #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
| ~ Use of this source code is governed by the Apache License 2.0 | ||
| ~ that can be found in the LICENSE file. | ||
| --> | ||
| === "Table" |
There was a problem hiding this comment.
Remember to add this table to the input variables md file manually.
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/routing.j2
Outdated
Show resolved
Hide resolved
Comment on lines
9
to
11
| router_service_insertion: | ||
| type: bool | ||
| description: Configure network services inserted to data forwarding |
There was a problem hiding this comment.
This should be a dict with an enabled flag. There are already TOIs with commands underneath this context, so even though we don't need those today, we should not block for adding them later.
ClausHolbechArista
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
implements
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Added in schem
How to test
molecule
Checklist
Repository Checklist