Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add knob to define port in GNMI transport grpc #3245

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

philippebureau
Copy link
Contributor

Change Summary

Add the capacity to define a custom port in management api gnmi for transport grpc

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

see molecule tests :
management-gnmi.yml
management-gnmi-new-flags.yml

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@philippebureau philippebureau requested review from a team as code owners October 16, 2023 14:40
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 16, 2023
@noredistribution
Copy link
Contributor

should we update the documentation? changing the gRPC Port might require update to the control-plane ACL

@philippebureau
Copy link
Contributor Author

philippebureau commented Oct 16, 2023 via email

Copy link
Contributor

@noredistribution noredistribution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine for me, I'd just add that note about the CP ACL and then it's good to go

@philippebureau
Copy link
Contributor Author

should we update the documentation? changing the gRPC Port might require update to the control-plane ACL

updated schema fragment description with your recommendation. Thank you

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 18, 2023
@ClausHolbechArista ClausHolbechArista merged commit ae7c25e into aristanetworks:devel Oct 19, 2023
39 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants