Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Implement management-ssh client-alive #3265

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 18, 2023

Change Summary

Add client-alive options for management-ssh

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

CLI output

ceos2(config-mgmt-ssh)#client-alive ?
  count-max  Number of keep-alive packets that can be sent without a response before the connection is assumed dead
  interval   Time period ( in seconds ) to send SSH keep-alive packets

ceos2(config-mgmt-ssh)#client-alive count-max ?
  <1-1000>  Set Value

ceos2(config-mgmt-ssh)#client-alive interval ?
  <1-1000>  Set Value

Adding the following schema:

      client_alive:
        type: dict
        keys:
          count_max:
            type: int
            convert_types:
              - str
            min: 1
            max: 1000
            description: Number of keep-alive packets that can be sent without a response before the connection is assumed dead.
          interval:
            type: int
            convert_types:
              - str
            min: 1
            max: 1000
            description: Time period (in seconds) to send SSH keep-alive packets.

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 18, 2023 22:48
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 18, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested settings on DUT

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Oct 19, 2023
@carlbuchmann carlbuchmann self-assigned this Oct 19, 2023
@ClausHolbechArista ClausHolbechArista merged commit 3e4b44b into aristanetworks:devel Oct 19, 2023
38 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants