Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Implement VRRP for ethernet interfaces #3276

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 20, 2023

Change Summary

Copied the "new" model from VLAN interfaces and checked it against a device, added some min/max where relevant (as well in VLAN)

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

VRRP current model for ethernet_interfaces

How to test

molecule test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 20, 2023 09:58
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 20, 2023
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Crossing fingers for CI to pass :)

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 25, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 25, 2023 09:18
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@carlbuchmann carlbuchmann merged commit 833b4f2 into aristanetworks:devel Nov 2, 2023
39 checks passed
@gmuloc gmuloc removed the role: eos_designs issue related to eos_designs role label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants