Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): LLDP for Management interfaces #3277

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Feat(eos_cli_config_gen): LLDP for Management interfaces #3277

merged 1 commit into from
Oct 20, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 20, 2023

Change Summary

Allow to configure

interface Management1
  no lldp transmit
  no lldp receive
  lldp tlv transmit ztp vlan 666

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Copied the schema from ethernet_interfaces

How to test

checked all options are accepted on cEOS
molecule test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 20, 2023 10:18
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 20, 2023
@ClausHolbechArista ClausHolbechArista requested a review from a team October 20, 2023 10:38
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 20, 2023
emilarista
emilarista approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed, LGTM!

@gmuloc gmuloc merged commit c93995d into aristanetworks:devel Oct 20, 2023
38 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmuloc @ClausHolbechArista @emilarista @carlbuchmann